Browse Source

Minor comments

master
Matthew Holt 5 years ago
parent
commit
792fca40f1
No known key found for this signature in database GPG Key ID: 2A349DD577D586A5
  1. 3
      modules/caddyhttp/server.go
  2. 2
      modules/caddytls/connpolicy.go

3
modules/caddyhttp/server.go

@ -74,6 +74,9 @@ type Server struct {
// handlers are executed sequentially. The sequence of invoked
// handlers comprises a compiled middleware chain that flows
// from each matching route and its handlers to the next.
//
// By default, all unrouted requests receive a 200 OK response
// to indicate the server is working.
Routes RouteList `json:"routes,omitempty"`
// Errors is how this server will handle errors returned from any

2
modules/caddytls/connpolicy.go

@ -66,7 +66,7 @@ func (cp ConnectionPolicies) TLSConfig(ctx caddy.Context) *tls.Config {
// using ServerName to match policies is extremely common, especially in configs
// with lots and lots of different policies; we can fast-track those by indexing
// them by SNI, so we don't have to iterate potentially thousands of policies
// (TODO: this map does not account for wildcards, see if this is a problem in practice?)
// (TODO: this map does not account for wildcards, see if this is a problem in practice? look for reports of high connection latency with wildcard certs but low latency for non-wildcards in multi-thousand-cert deployments)
indexedBySNI := make(map[string]ConnectionPolicies)
if len(cp) > 30 {
for _, p := range cp {

Loading…
Cancel
Save